Github user fafaman commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/93#issuecomment-211828264
@omefire I am not too keen on seeking to the end of file: Is this module
not supposed to be able to play a stream? To be clear, this patch was done
while looking after a problem of codrova app restarting when the phone is
plugged or unplugged from a car audio stand. I seams that an event telling the
app the audio system has changed provoques that app restart. I first thought
the app restart was due to that null pointer exception, but once fixed, the app
still restarts... I decided to propose the patch (as well as CB-11085) so this
work is not lost, and code cleaner for going forward. In my opinion, the real
problem comes from before during the player creation: we should not have
this.players.get(id) returning a non null while the player is null.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
