Github user riknoll commented on a diff in the pull request:

    https://github.com/apache/cordova-paramedic/pull/5#discussion_r62402014
  
    --- Diff: lib/utils/utilities.js ---
    @@ -40,6 +40,57 @@ function getSimulatorsFolder() {
         return simulatorsFolderPath;
     }
     
    +function getDeviceId() {
    --- End diff --
    
    Can this perhaps be renamed to something like `getSimulatorModel`? The name 
sort of implies that it gets the id for a physical device (when compared to 
`getSimulatorId`)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to