Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/116#discussion_r63143895
--- Diff: src/nightly.js ---
@@ -45,19 +54,26 @@ module.exports = function*(argv) {
desc: 'Don\'t actually publish to npm, just print what would
be run.',
type:'boolean'
})
+ .options('ignore-test-failures', {
+ desc: 'Run the tests for cli and lib but don\'t fail the build
if the tests are failing',
+ type:'boolean',
+ alias : 'ignoreTestFailures'
+ })
.argv;
if(argv.h) {
optimist.showHelp();
process.exit(1);
}
-
+
//Grab currently published nightly version so we can unpublish it later
- //Assumes lib and cli have same version
- var oldNightlyVersion = yield executil.execHelper(executil.ARGS('npm
view cordova dist-tags.nightly'));
- console.log(oldNightlyVersion);
+ var oldNightlyVersions = {};
+ oldNightlyVersions.cli = yield executil.execHelper(executil.ARGS('npm
view cordova dist-tags.nightly'));
+ oldNightlyVersions.lib = yield executil.execHelper(executil.ARGS('npm
view cordova-lib dist-tags.nightly'));
+ console.log('oldNightlyVersions: ' +
JSON.stringify(oldNightlyVersions));
--- End diff --
Please use `apputil.print` to make logging consistent. Also could you
please update this to print human-readable output instead of raw JSON
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
