Github user alsorokin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/209#discussion_r63490344
--- Diff: appium-tests/helpers/cameraHelper.js ---
@@ -103,11 +109,185 @@ module.exports.getPicture = function (opts, pid) {
}, opts);
};
-module.exports.checkPicture = function (pid, cb) {
+// verifies taken picture when the promise is resolved,
+// calls a callback with 'OK' if everything is good,
+// calls a callback with 'ERROR: <error message>' if something is wrong
+// note that this function is executed in the context of tested app
+// and not in the context of tests
+module.exports.checkPicture = function (pid, options, cb) {
+ var isIos = cordova.platformId === "ios";
+ var isAndroid = cordova.platformId === "android";
+ // skip image type check if it's unmodified on Android:
+ // https://github.com/apache/cordova-plugin-camera/#android-quirks-1
+ var skipFileTypeCheck = isAndroid &&
+ (!options.quality || options.quality === 100) &&
--- End diff --
Default quality 100 sounds like a good idea, especially if it'll help
reduce memory usage.
It is also intuitive: I was expecting it to be 100.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
