Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/253#discussion_r64092365
--- Diff: src/cli.js ---
@@ -143,20 +143,27 @@ module.exports = function (inputArgs, cb) {
return cli(inputArgs);
}).then(function () {
if (shouldCollectTelemetry && !isTelemetryCmd) {
- telemetry.track(cmd, 'successful');
+ telemetry.track(cmd, subcommand, 'successful');
}
// call cb with error as arg if something failed
cb(null);
}).fail(function (err) {
if (shouldCollectTelemetry && !isTelemetryCmd) {
- telemetry.track(cmd, 'unsuccessful');
+ telemetry.track(cmd, subcommand, 'unsuccessful');
--- End diff --
Ah, I see you check for it below. I think the code might be cleaner/easier
to understand if you just do the check here rather than manually deleting null
values from the arguments array.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
