Github user sinzianag commented on the pull request:
https://github.com/apache/cordova-plugin-device-orientation/pull/19
Most calls to Location Manager require permissions that in android 5.0+
need to be handled at runtime (ACCESS_COARSE_LOCATION,ACCESS_FINE_LOCATION) and
I don't see any code in this PR that handles that.
Other plugins seem to be using the [Permission Helper from compat
plugin](https://github.com/apache/cordova-plugin-compat/blob/master/src/android/PermissionHelper.java).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
