Github user juliascript commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/234#discussion_r70534998 --- Diff: bin/templates/scripts/cordova/lib/plugman/pluginHandlers.js --- @@ -66,17 +66,19 @@ var handlers = { install:function(obj, plugin, project, options) { var src = obj.src, custom = obj.custom; - if (!custom) { var keepFrameworks = keep_these_frameworks; - if (keepFrameworks.indexOf(src) < 0) { - project.xcode.addFramework(src, {weak: obj.weak}); - project.frameworks[src] = (project.frameworks[src] || 0) + 1; + if (keepFrameworks.indexOf(src) < 0) { + if (obj.type === 'podspec') { + //podspec handled in Api.js + } else { + project.frameworks[src] = (project.frameworks[src] || 0) + 1; --- End diff -- Changed to project.frameworks[src] = project.frameworks[src] || 0; project.frameworks[src]++; for now, should definitely be refactored in the future.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org