Github user jcesarmobile commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/62#discussion_r76540305
--- Diff: src/ios/CDVStatusBar.m ---
@@ -200,8 +202,8 @@ - (void) initializeStatusBarBackgroundView
- (CGRect) invertFrameIfNeeded:(CGRect)rect {
// landscape is where (width > height). On iOS < 8, we need to invert
since frames are
- // always in Portrait context
- if (UIInterfaceOrientationIsLandscape([[UIApplication
sharedApplication] statusBarOrientation]) && (rect.size.width <
rect.size.height)) {
+ // always in Portrait context. Do not run this on ios 8 or above to
avoid breaking ipad pro multitask layout
+ if (!IsAtLeastiOSVersion(@"8.0") &&
UIInterfaceOrientationIsLandscape([[UIApplication sharedApplication]
statusBarOrientation]) && (rect.size.width < rect.size.height)) {
--- End diff --
You can remove the `rect.size.width < rect.size.height` part as that will
only be true on iOS 7 and earlier and you already added the
`!IsAtLeastiOSVersion(@"8.0")` check
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
