OK, so it's been a while. I think we're ready for a release of this soon. I just have to fix up check_reqs so it works, and then we can move forward with the Cordova-Android 6.0.0 release.
Should we start the vote thread on Monday? On Tue, Sep 13, 2016 at 11:24 AM, Joe Bowser <bows...@gmail.com> wrote: > No, I have no intention of pulling that into this release, since the > corresponding Android code caused performance issues due to numerous file > reads. > > On Tue, Sep 13, 2016 at 11:21 AM, Darryl Pogue <dar...@dpogue.ca> wrote: > >> Just wanted to check whether this cordova-lib change was intended to get >> pulled in as part of the Cordova Android 6 release: >> https://github.com/apache/cordova-lib/pull/469 >> >> If it is, I have an additional commit to add that fixes the JS spec tests: >> https://github.com/infil00p/cordova-lib/pull/1 >> >> >> On 13 September 2016 at 10:30, Joe Bowser <bows...@gmail.com> wrote: >> >> > OK, so it looks like all our ducks are lined up and we should be ready >> for >> > a 6.0 release pretty soon. How do people feel about doing testing this >> > week, and getting the vote thread going on Monday? I know the vote >> thread >> > is only 72 hours, so I want a bit more testing on the major before we >> do it >> > because the PRs haven't been getting the attention that I wanted them >> to. >> > >> > What do people think? >> > >> > On Thu, Sep 8, 2016 at 2:54 PM, Shazron <shaz...@gmail.com> wrote: >> > >> > > Ask Crosswalk to: >> > > "To detach the fork and turn it into a standalone repository on >> GitHub, >> > > contact GitHub Support." >> > > >> > > From: >> > > https://help.github.com/articles/why-are-my- >> > contributions-not-showing-up- >> > > on-my-profile/ >> > > >> > > >> > > >> > > On Thu, Sep 8, 2016 at 2:46 PM, Joe Bowser <bows...@gmail.com> wrote: >> > > >> > > > Hey >> > > > >> > > > So, this is exciting. Things are broken on Master if you're trying >> to >> > > use >> > > > Cordova with Jellybean. Apparently we forgot to add a failsafe for >> the >> > > > bridge to go back to APIs lower than 19, so the bridge doesn't work >> if >> > > > you're targeting people still on Jellybean. Unfortunately, we still >> > have >> > > > to support Jellybean despite the fact that their jsToNativeBridge is >> > > > prompt. >> > > > >> > > > Also, I just realized that I can't send a PR to Crosswalk, since I >> own >> > > the >> > > > initial crosswalk repo on GitHub. (Oops!) This means that I need >> > someone >> > > > from the Crosswalk project to adopt these changes here to get this >> to >> > > work >> > > > on Cordova-Android 6.0.0 >> > > > >> > > > https://github.com/infil00p/cordova-crosswalk-engine/tree/ >> > > Crosswalk_Compat >> > > > >> > > > I'm tempted to nuke the thing in the near future, since the >> Crosswalk >> > > > Project should be managing the repository and their repository >> should >> > be >> > > > the canonical source for everything Crosswalk/Cordova related and >> not >> > my >> > > > prototype repo. :P >> > > > >> > > > So, is anyone using the stock webview for Jellybean, and should we >> > spend >> > > > time fixing this issue? We changed the webview because we found that >> > > using >> > > > multiple webviews in an application was falling apart, and we needed >> > this >> > > > change for stability so we knew which callbacks go to which >> instance of >> > > > webview. However, if people reviewed the patch requests, they would >> > have >> > > > noticed that this doesn't work on API 16. :( >> > > > >> > > > I'm going to go by the assumption that we want this fixed until I >> hear >> > > > otherwise for now. That said, if people think it's reasonable to >> > > recommend >> > > > that people targeting Jellybean use Crosswalk, I'm cool with that as >> > > well. >> > > > >> > > > Thoughts? >> > > > >> > > > >> > > > >> > > > On Tue, Sep 6, 2016 at 11:25 AM, julio cesar sanchez < >> > > > jcesarmob...@gmail.com >> > > > > wrote: >> > > > >> > > > > Those 2 lines have minSdkVersion 14 >> > > > > >> > > > > https://github.com/apache/cordova-android/blob/master/ >> > > > > framework/AndroidManifest.xml#L22 >> > > > > https://github.com/apache/cordova-android/blob/master/ >> > > > > test/AndroidManifest.xml#L48 >> > > > > >> > > > > Maybe I looked into the wrong place and that is not being used >> > > > > >> > > > > >> > > > > >> > > > > El martes, 6 de septiembre de 2016, Joe Bowser <bows...@gmail.com >> > > > > <javascript:_e(%7B%7D,'cvml','bows...@gmail.com');>> escribió: >> > > > > >> > > > > > On Tue, Sep 6, 2016 at 11:14 AM, julio cesar sanchez < >> > > > > > jcesarmob...@gmail.com >> > > > > > > wrote: >> > > > > > >> > > > > > > Now we shouldn't forget to increase the minSdkVersion. I >> couldn't >> > > > find >> > > > > an >> > > > > > > issue open for this. Which API level did we say that we will >> > > support? >> > > > > 16? >> > > > > > > >> > > > > > > >> > > > > > Yes, we said 16. I already did it when bumping up to API 24, >> but >> > an >> > > > > issue >> > > > > > would be nice. >> > > > > > >> > > > > > >> > > > > > > >> > > > > > > El martes, 6 de septiembre de 2016, Joe Bowser < >> > bows...@gmail.com> >> > > > > > > escribió: >> > > > > > > >> > > > > > > > Merging the nougat_update code today. Master will now be >> > > targeting >> > > > > API >> > > > > > > 24. >> > > > > > > > >> > > > > > > > On Fri, Sep 2, 2016 at 11:21 AM, Joe Bowser < >> bows...@gmail.com >> > > > > > > > <javascript:;>> wrote: >> > > > > > > > >> > > > > > > > > Yeah, I already added android-24 to that line, and now the >> > > error >> > > > is >> > > > > > > even >> > > > > > > > > more explicit and it's telling me straight up to install >> > it. I >> > > > > need >> > > > > > > > > someone to install android-24 on Travis. >> > > > > > > > > >> > > > > > > > > On Fri, Sep 2, 2016 at 11:19 AM, Jesse < >> > > purplecabb...@gmail.com >> > > > > > > > <javascript:;>> wrote: >> > > > > > > > > >> > > > > > > > >> https://github.com/apache/cordova-android/blob/master/. >> > travi >> > > > > > s.yml#L9 >> > > > > > > > >> >> > > > > > > > >> >> > > > > > > > >> @purplecabbage >> > > > > > > > >> risingj.com >> > > > > > > > >> >> > > > > > > > >> On Thu, Sep 1, 2016 at 10:59 AM, Joe Bowser < >> > > bows...@gmail.com >> > > > > > > > <javascript:;>> wrote: >> > > > > > > > >> >> > > > > > > > >> > BTW: The nougat update has been added, but this broke >> our >> > CI >> > > > > > > > >> > >> > > > > > > > >> > https://travis-ci.org/apache/cordova-android/builds/ >> > > 156860827 >> > > > > > > > >> > >> > > > > > > > >> > Can we get android-24 added to Travis? >> > > > > > > > >> > >> > > > > > > > >> > >> > > > > > > > >> > >> > > > > > > > >> > On Thu, Sep 1, 2016 at 8:48 AM, Joe Bowser < >> > > bows...@gmail.com >> > > > > > > > <javascript:;>> wrote: >> > > > > > > > >> > >> > > > > > > > >> > > Sounds good! >> > > > > > > > >> > > >> > > > > > > > >> > > On Thu, Sep 1, 2016 at 8:48 AM, julio cesar sanchez < >> > > > > > > > >> > > jcesarmob...@gmail.com <javascript:;>> wrote: >> > > > > > > > >> > > >> > > > > > > > >> > >> You asked for a reason to NOT do it, so if there is >> no >> > > > answer >> > > > > > you >> > > > > > > > >> can do >> > > > > > > > >> > >> it. >> > > > > > > > >> > >> >> > > > > > > > >> > >> >> > > > > > > > >> > >> >> > > > > > > > >> > >> 2016-09-01 17:44 GMT+02:00 Joe Bowser < >> > bows...@gmail.com >> > > > > > > > <javascript:;>>: >> > > > > > > > >> > >> >> > > > > > > > >> > >> > BUMP!!! >> > > > > > > > >> > >> > >> > > > > > > > >> > >> > This is a major version! Are people getting my >> > e-mails? >> > > > > > > > >> > >> > >> > > > > > > > >> > >> > On Wed, Aug 31, 2016 at 12:44 PM, Joe Bowser < >> > > > > > > bows...@gmail.com >> > > > > > > > <javascript:;>> >> > > > > > > > >> > wrote: >> > > > > > > > >> > >> > >> > > > > > > > >> > >> > > Hey >> > > > > > > > >> > >> > > >> > > > > > > > >> > >> > > This week, I'm going to start merging things >> that >> > > will >> > > > > > break >> > > > > > > > >> certain >> > > > > > > > >> > >> > APIs, >> > > > > > > > >> > >> > > such as the Third Party WebView. This is done >> so >> > we >> > > > can >> > > > > > have >> > > > > > > > >> solid >> > > > > > > > >> > >> > > compatibility with Nougat, as well as fix some >> > > > threading >> > > > > > > issues >> > > > > > > > >> that >> > > > > > > > >> > >> > people >> > > > > > > > >> > >> > > are having when embedding CordovaWebView in >> native >> > > > > > projects. >> > > > > > > > >> Before >> > > > > > > > >> > >> I do >> > > > > > > > >> > >> > > this, I need to know whether there's any reason >> to >> > > NOT >> > > > do >> > > > > > > this. >> > > > > > > > >> > >> > > >> > > > > > > > >> > >> > > Does anyone have any objections to me starting >> to >> > > merge >> > > > > the >> > > > > > > > 6.0.x >> > > > > > > > >> > >> changes >> > > > > > > > >> > >> > > in and prepping for a 6.0.x release sometime in >> > > > September >> > > > > > > with >> > > > > > > > >> > Cordova >> > > > > > > > >> > >> > > targeting API 24, and having compatibility >> fixes? >> > > > > > > > >> > >> > > >> > > > > > > > >> > >> > > Joe >> > > > > > > > >> > >> > > >> > > > > > > > >> > >> > >> > > > > > > > >> > >> >> > > > > > > > >> > > >> > > > > > > > >> > > >> > > > > > > > >> > >> > > > > > > > >> >> > > > > > > > > >> > > > > > > > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > >> > >> > >
