Hi Kerri, which changes? Is it related to my fix for the code in prepare.js? I think we should push this fix for 4.3.1, which I will launch a.s.a.p once there is a PR for it :)
On Sat, Oct 22, 2016 at 9:28 PM, Kerri Shotts <kerrisho...@gmail.com> wrote: > So, while testing for the VOTE thread, I discovered that a couple recent > changes have broken launch image storyboard support. As it stands now, the > broken code does NOT break existing functionality — it just means that > should a user utilize the launch storyboard image feature, it will render > as a white splash screen. The app itself would still work. > > I’ve figured out the fix — a couple of lines need tweaking in prepare.js, > but I don’t want to hold up 4.3.0 unnecessarily as there are lots of other > important features to get out. If we wanted, we could release the above fix > in 4.3.1 and promote launch storyboard images then. Although if there’s a > quick way to pull the fix in, that’d be my preference… :-) > > Thoughts? > > ~ Kerri > > > On Oct 20, 2016, at 15:38, Shazron <shaz...@gmail.com> wrote: > > > > Chock full of new features: > > - CocoaPods (static libs only) support as <framework> > > - Xcode 8 / iOS 10 support > > - buildFlag support on the command line > > - iPad storyboard support > > - others that I may have forgot > > > > All the outstanding PRs and (according to me) issues that can get fixed > > are in. > > > > Let me know if there are any concerns, if not I'll start the vote > tomorrow. > >
