Github user vladimir-kotikov commented on the pull request:

    
https://github.com/apache/cordova-lib/commit/99931eb03cc440e5fb5d7721abb92aa4938fe30e#commitcomment-19630108
  
    I'm not sure but there might be a logical error - we probably should not 
tell user that there was an error when there is no such module (i.e. `err.code 
=== 'MODULE_NOT_FOUND'`) and no deprecation information in 
`platforms[platform]`, because this just means that platform does not support 
this.
    
    ```js
    if (err && err.code === 'MODULE_NOT_FOUND') {
        if (platforms[platform].apiCompatibleSince) {
            // print depreaction mesage
        }
        // do not print anything
    } else {
        // print 'error loading ...'
    }
    ```
    
    /cc @imhotep


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to