Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/213#discussion_r92344562
--- Diff: template/cordova/lib/JsprojManager.js ---
@@ -121,7 +121,12 @@ jsprojManager.prototype = {
copyToOutputDirectory.text = 'Always';
children.push(copyToOutputDirectory);
- var item = createItemGroupElement('ItemGroup/Content', sourcePath,
targetConditions, children);
+ var item;
--- End diff --
IMO it'd be better to calculate path for `content` element outside this
method (in `'resource-file'.install`) - this way you will avoid checking the
same condition (`if (targetConditions.reference) ...`) twice and won't need to
modify this method at all.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
