GitHub user mad-nuts opened a pull request:
https://github.com/apache/cordova-plugin-contacts/pull/146
CB-12326
fix:
Crash on Android: CommonDataKinds.*.LABEL
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### What does this PR do?
Adding the missing "LABEL" CommonDataKinds columns to the
ContactAccessorSdk5 to fix the app crash issue.
Moving the label type queries inside the try catch blocks, replacing the
"getColumnIndex" with "getColumnIndexOrThrow" and catching the
IllegalArgumentExceptions handler to make the code more solid.
### What testing has been done on this change?
Tested on Samsung Galaxy S6
### Checklist
- [ Yes ] [Reported an
issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [ Yes ] Commit message follows the format: "CB-3232: (android) Fix bug
with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the
platform affected.
- [ No ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mad-nuts/cordova-plugin-contacts master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-contacts/pull/146.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #146
----
commit 3bb509e1f473531354b70fd299ba2003905d3f5b
Author: andreas.kausler <[email protected]>
Date: 2017-01-06T13:59:21Z
CB-12326
fix:
Crash on Android: CommonDataKinds.*.LABEL
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
