GitHub user kerrishotts opened a pull request:
https://github.com/apache/cordova-ios/pull/286
CB-12287: Remove hardcoded simulator build destination
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
iOS 4.3.1 and below
### What does this PR do?
In `[email protected]` and below, the Xcode build destination when building
for a simulator is hardcoded as "iPhone 5s". This works as long as the user has
an iPhone 5s simulator installed, but if they remove it, the build process
breaks.
This PR follows the same logic as `cordova emulate ios` in choosing a
default destination, but also respects `--target` if specified. For example:
```
$ cordova emulate ios # will currently select iPhone SE simulator
to build against and emulate
$ cordova emulate ios --target="iPhone-7-Plus" # will build against
and emulate on the iPhone 7+
```
If there are no simulators available, the behavior is undefined, but Xcode
wouldn't be able to build either.
### What testing has been done on this change?
Manual tests and `npm test`
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [X] Added automated test coverage as appropriate for this change.
- Note: a couple of tests were modified so that they could pass, but
they don't actually test this issue. Tests covering the inner logic will come
in a separate PR
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kerrishotts/cordova-ios CB-12287
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/286.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #286
----
commit 3c0ba16324c44440892beec1fd4c741714836cd2
Author: Kerri Shotts <[email protected]>
Date: 2017-01-10T05:29:00Z
CB-12287: Remove hardcoded simulator build destination
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
