Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r95500726
--- Diff: cordova-lib/spec-cordova/plugin.spec.js ---
@@ -145,30 +146,36 @@ describe('plugin end-to-end', function() {
expect(errorHandler.errorCallback).not.toHaveBeenCalled();
});
- it('should successfully add and remove a plugin with no options',
function(done) {
+ it('Test 001 : should successfully add and remove a plugin with no
options', function(done) {
addPlugin(path.join(pluginsDir, 'fake1'), pluginId, {}, done)
.then(function() {
return removePlugin(pluginId);
})
- .fail(errorHandler.errorCallback)
+ .fail(function(err) {
+ console.error(err);
+ expect(err).toBeUndefined();
+ })
.fin(done);
- });
+ }, 30000);
- it('should run prepare after plugin installation/removal by default',
function(done) {
+ it('Test 002 : should run prepare after plugin installation/removal by
default', function(done) {
addPlugin(path.join(pluginsDir, 'fake1'), pluginId, {})
.then(function() {
expect(prepare.preparePlatforms).toHaveBeenCalled();
- prepare.preparePlatforms.reset();
+ prepare.preparePlatforms.calls.reset();
return removePlugin(pluginId);
})
.then(function () {
expect(prepare.preparePlatforms).toHaveBeenCalled();
})
- .fail(errorHandler.errorCallback)
+ .fail(function(err) {
+ console.error(err);
--- End diff --
same as 155
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
