GitHub user TommiKetola opened a pull request:
https://github.com/apache/cordova-plugin-media/pull/129
(android) Fix NullPointerException in AudioPlayer.readyPlayer
### Platforms affected
Android
### What does this PR do?
Fixes null pointer exception with following path:
#0. Crashed: JavaBridge: 0 0 0x0000000000000000
at java.lang.String.compareTo(String.java)
at
org.apache.cordova.media.AudioPlayer.readyPlayer(AudioPlayer.java:583)
at
org.apache.cordova.media.AudioPlayer.startPlaying(AudioPlayer.java:299)
at
org.apache.cordova.media.AudioHandler.resumeAllGainedFocus(AudioHandler.java:414)
at
org.apache.cordova.media.AudioHandler$1.onAudioFocusChange(AudioHandler.java:431)
Mechanism: resumeAllGainedFocus() calls startPlaying(null) and null value
is not handled properly in readyPlayer().
### What testing has been done on this change?
Only crash scenario has been tested (performs only extra validation)
### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mandorla-fi/cordova-plugin-media master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-media/pull/129.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #129
----
commit 872501865da00c476f245d1303507979c46b68ac
Author: Tommi Ketola <[email protected]>
Date: 2017-02-21T10:33:21Z
Avoid compareTo exception with null argument.
commit 7e61e1f2aff5abf927b2734cebceda6867279695
Author: Tommi Ketola <[email protected]>
Date: 2017-02-21T11:37:47Z
Change more idiomatic.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
