Github user audreyso commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/522#discussion_r103526011
  
    --- Diff: cordova-lib/src/plugman/fetch.js ---
    @@ -257,7 +237,7 @@ function checkID(expectedIdAndVersion, pinfo) {
         var parsedSpec = pluginSpec.parse(expectedIdAndVersion);
     
         if (parsedSpec.id != pinfo.id) {
    -        var alias = parsedSpec.scope ? null : 
pluginMappernto[parsedSpec.id] || pluginMapperotn[parsedSpec.id];
    +        var alias = null;
             if (alias !== pinfo.id) {
    --- End diff --
    
    kk thanks! @stevengill  If you remove this code, there are tests that go 
with it and they will fail so I removed those in the next commit. How does this 
look? 
https://github.com/apache/cordova-lib/pull/522/commits/a29720e6d6b2378d9e342a5b1bb46bef1db17fa8


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to