GitHub user filmaj opened a pull request: https://github.com/apache/cordova-lib/pull/525
CB-12557: superspawn now returns both stdout and stderr in reject handler Please review @stevengill and @audreyso. ### Platforms affected All. ### What does this PR do? This solves [CB-12557](https://issues.apache.org/jira/browse/CB-12557). Some programs pump output to both stdout and stderr when exit codes are non-zero (i.e. `android`). It would be nice to get access to both streams in the reject handler. In particular, to solve the suite of new issues arising from the updated Android SDK Tools in 25.3.1 ([CB-12554](https://issues.apache.org/jira/browse/CB-12554)), we need to detect when the `android` command exits with a non-zero status code _and_ contains particular language in `stdout`. This change to `superspawn` allows for that level of introspection. ### What testing has been done on this change? Ran `npm test` on master branch, all tests pass. Then ran `npm test` on this branch, which includes a new test covering this case, all tests pass. ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/filmaj/cordova-lib CB-12557 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/525.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #525 ---- commit c744fafc6ffc985cf80f0abb2fa799111331a07f Author: filmaj <maj....@gmail.com> Date: 2017-03-09T15:18:34Z CB-12557: add both stdout and stderr properties to the error object passed to superspawn reject handler. ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org