I vote +1: * Ran coho verify-archive * Ran unit tests repo * unpacked, npm i, and npm tested * built and ran hello world app via cli
@purplecabbage risingj.com On Tue, Apr 25, 2017 at 10:28 AM, Steven Gill <stevengil...@gmail.com> wrote: > I vote +1: > * Ran coho audit-license-headers over the relevant repos > * Ran coho check-license to ensure all dependencies and subdependencies > have Apache-compatible licenses > * Ran unit tests in cordova-ios repo > * built and ran hello world app via cli > > On Mon, Apr 24, 2017 at 6:08 PM, Shazron <shaz...@apache.org> wrote: > > > Please review and vote on this 4.4.0 iOS Release > > by replying to this email (and keep discussion on the DISCUSS thread) > > > > Release issue: https://issues.apache.org/jira/browse/CB-12687 > > > > The archive has been published to dist/dev: > > https://dist.apache.org/repos/dist/dev/cordova/CB-12687 > > > > The package was published from its corresponding git tag: > > cordova-ios: 4.4.0 (6b25611ae9) > > > > Note that you can test it out via: > > > > cordova platform add https://github.com/apache/cordova-ios#4.4.0 > > > > Upon a successful vote I will upload the archive to dist/, publish it to > > npm, and post the blog post. > > > > Voting guidelines: > > https://github.com/apache/cordova-coho/blob/master/docs/ > release-voting.md > > > > Voting will go on for a minimum of 48 hours. > > > > I vote +1: > > * Ran coho audit-license-headers over the relevant repos > > * Ran coho check-license to ensure all dependencies and subdependencies > > have Apache-compatible licenses > > * Ensured continuous build was green when repo was tagged > > >
