GitHub user feichngr opened a pull request:
https://github.com/apache/cordova-lib/pull/549
CB-12705: Pass plugin info to project-level plugin hooks
### Platforms affected
Cordova-cli and maybe plugman
### What does this PR do?
Makes sure plugin information is passed to project-level
`before_plugin_uninstall`, `before_plugin_install`, and `after_plugin_install`
hooks.
### What testing has been done on this change?
Other than modifying the test spec for `HooksRunner.js`, I created a small
test project with `before_plugin_uninstall`, `before_plugin_install`, and
`after_plugin_install` js-hooks configured in `config.xml` which print the
context to console. They now output plugin information just like they do for
plugin hooks.
### Checklist
- [x ] [Reported an
issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [x] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/feichngr/cordova-lib CB-12705
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/549.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #549
----
commit 8be488517419b7beb4d7c6c613012e977684aa50
Author: feichngr <[email protected]>
Date: 2017-04-25T16:16:11Z
CB-12705: Pass plugin info to project *_plugin_install hooks
Before running runScriptViaModuleLoader context.opts.plugin already
contains information on the plugin. Modified the function so that the field is
only overridden if the script comes from a plugin.
commit 7a947c0c874bb7d0c8b6710ffc9dd4248ec79e35
Author: feichngr <[email protected]>
Date: 2017-04-26T05:45:01Z
CB-12705: Modified (before|after)_plugin_(uninstall|install) to always
expect existence of plugin field
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
