Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/562#discussion_r122224237
--- Diff: spec-cordova/platform/addHelper.spec.js ---
@@ -0,0 +1,515 @@
+/**
--- End diff --
Sort of. The old tests I `xdescribe`d them so they don't run. Instead,
based on the code and general purpose of the `addHelper` module, I wrote up
four `it()` statements describing tests we should implement to get decent
coverage and exercise the spirit of the module. I also added a big mulitline
comment roughly sketching out what `addHelper` does - we should convert that
comment into more `it()` statements to lay out the overview of unit tests for
this module.
Finally, we should go over the old tests I `xdescribe`d at the bottom and
figure out a) if we already have the coverage for what those tests do
elsewhere, or if not b) write up unit tests to replace them (possibly in a
different module - depends on what the test is testing).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
