This vote has failed. I will send out a new one shortly On Tue, Sep 19, 2017 at 10:28 PM, Steven Gill <stevengil...@gmail.com> wrote:
> nice catch. > > On Tue, Sep 19, 2017 at 8:10 PM, Simon MacDonald < > simon.macdon...@gmail.com> wrote: > >> I vote - 1 >> >> Passed >> * Checked for deprecation notices for plugin-device-motion & orientation >> * Tested that cordova-plugin-console is not added for ios when cordova-ios >> >= 4.5.0 >> * Tested that cordova-plugin-compat is not added for android when >> cordova-android >= 6.3.0 >> >> Failed >> * Added cordova-plugin-camera to a project with cordova-android 6.3.0 >> which >> depends on cordova-plugin-compat and the build fails. >> >> The reason the build fails is that all of the cordova plugins that depend >> on cordova-plugin-compat do so using a semver of ^1.0.0 or ^1.1.0. Since >> compat was bumped to 2.0.0 when you install cordova-plugin-camera on your >> cordova-android 6.3.0 project it fails the semver and it pulls in the >> 1.1.0 >> version. Now both compat and cordova-android deliver the same classes and >> the build fails. >> >> >> >> Simon Mac Donald >> http://simonmacdonald.com >> >> On Mon, Sep 18, 2017 at 7:05 PM, Audrey So <a...@adobe.com.invalid> >> wrote: >> >> > I vote + 1 >> > >> > * Verified signatures >> > >> > * Checked for deprecation notices for plugin-device-motion & orientation >> > * Tested that cordova-plugin-console is not added for ios >> > * Tested that cordova-plugin-compat is not added for android >> > * Added plugins to cordova project >> > >> > >> > >> > >> > On 9/18/17, 3:05 PM, "Joe Bowser" <bows...@gmail.com> wrote: >> > >> > >I vote +1 >> > > >> > >* Tested cordova-plugin-compat installation to make sure it doesn't >> > install >> > >on cordova-android master >> > >* Ran mobilespec locally >> > >* Verified signatures >> > > >> > > >> > >On Mon, Sep 18, 2017 at 2:08 PM, Steven Gill <stevengil...@gmail.com> >> > wrote: >> > > >> > >> Please review and vote on the release of this plugins release >> > >> by replying to this email (and keep discussion on the DISCUSS thread) >> > >> >> > >> Release issue: https://na01.safelinks.protection.outlook.com/?url= >> > https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB- >> > 13294&data=02%7C01%7C%7C14e404d7c0e7454c718b08d4fee1591a% >> > 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636413691211640629&sdata=% >> > 2B2sZF4YE7bcA8vA4%2BqZgknBBArYMn0mbzXFQMlwkGR4%3D&reserved=0 >> > >> >> > >> The plugins have been published to >> > >> dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13294/ >> > >> >> > >> The packages were published from their corresponding git tags: >> > >> cordova-plugin-console: 2.0.0 (f0e113bdf4) >> > >> cordova-plugin-compat: 2.0.0 (0df201c24d) >> > >> cordova-plugin-device-motion: 2.0.0 (1236b957af) >> > >> cordova-plugin-device-orientation: 2.0.0 (d6b3322fcb) >> > >> >> > >> Upon a successful vote I will upload the archives to dist/, upload >> > >> them to npm, and post the corresponding blog post. >> > >> >> > >> Voting guidelines: >> > >> https://na01.safelinks.protection.outlook.com/?url= >> > https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%2Fblob% >> 2Fmaster%2Fdocs% >> > 2Frelease-voting.md&data=02%7C01%7C%7C14e404d7c0e7454c718b08d4fee1591a% >> > 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636413691211640629&sdata= >> > TH5HU27%2FrfoPu6ZjCmQ8ZsLHx2W8LwUCwzSsQ0VCMhA%3D&reserved=0 >> > >> How to vote on a plugins release at >> > >> https://na01.safelinks.protection.outlook.com/?url= >> > https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho% >> > 2Fblob%2Fmaster%2Fdocs%2Fplug&data=02%7C01%7C% >> > 7C14e404d7c0e7454c718b08d4fee1591a%7Cfa7b1b5a7b34438794aed2c178de >> > cee1%7C0%7C0%7C636413691211640629&sdata=QpsOtFm7U0IYm0RjMC4RQxThr0vb9u >> > nJ5YuXH6yrrjc%3D&reserved=0 >> > >> ins-release-process.md#voting >> > >> >> > >> Voting will go on for a minimum of 48 hours. >> > >> >> > >> I vote +1: >> > >> * Ran coho audit-license-headers over the relevant repos >> > >> * Ran coho check-license to ensure all dependencies and >> > >> subdependencies have Apache-compatible licenses >> > >> * Ensured continuous build was green when repos were tagged >> > >> >> > >> > >
