Github user audreyso commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/602#discussion_r147014589
  
    --- Diff: src/cordova/util.js ---
    @@ -255,11 +255,20 @@ function findPlugins (pluginDir) {
         var plugins = [];
     
         if (fs.existsSync(pluginDir)) {
    -        plugins = fs.readdirSync(pluginDir).filter(function (fileName) {
    -            var pluginPath = path.join(pluginDir, fileName);
    -            var isPlugin = isDirectory(pluginPath) || 
isSymbolicLink(pluginPath);
    -            return fileName !== '.svn' && fileName !== 'CVS' && isPlugin;
    -        });
    +        plugins = fs.readdirSync(pluginDir)
    +            .reduce(function (plugins, pluginOrScope) {
    +                if (pluginOrScope[0] === '@') {
    +                    plugins.push(...fs.readdirSync(path.join(pluginDir, 
pluginOrScope)).map(s => path.join(pluginOrScope, s)));
    --- End diff --
    
    Thanks for your question! We are sticking to the current style for now. We 
need to have a discussion on our mailing list about starting to use es2015 
features/ which ones to use and get some consensus.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to