I vote +1: * Ran coho verify-license * Npm test On Thu, Oct 26, 2017 at 2:12 PM, Audrey So <a...@adobe.com.invalid> wrote:
> I vote +1: > * Ran coho audit-license-headers > * Ran coho check-license > * Ran/tested mobilespec > * Created hello-world app, deployed to emulator > * Npm test > > > > > > On 10/25/17, 3:33 PM, "Suraj Pindoria" <pindoria.su...@gmail.com> wrote: > > >Please review and vote on this 4.5.3 iOS Release by replying to this email > >(and keep discussion on the DISCUSS thread) > > > >Release issue: https://na01.safelinks.protection.outlook.com/?url= > https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB- > 13493&data=02%7C01%7C%7Ce084f1f69b0e4617a32808d51bf87b7b% > 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636445676415459887&sdata= > wlUecnAkiLyoHza2DYKZJEoksnJZ5I7kLHJdXeOUw7k%3D&reserved=0 > > > >The archive has been published to dist/dev: > >https://na01.safelinks.protection.outlook.com/?url= > https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev% > 2Fcordova%2FCB-13493&data=02%7C01%7C%7Ce084f1f69b0e4617a32808d51bf87b7b% > 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636445676415459887&sdata= > s1wnAe0cBc3yI%2Fhaa3AkfyqG9xz1qnVU3tEVypyrpic%3D&reserved=0 > > > >The package was published from its corresponding git tag: > > cordova-ios: 4.5.3 (ce2ab968e7) > > > >Note that you can test it out via: > > > > cordova platform add https://na01.safelinks. > protection.outlook.com/?url=https%3A%2F%2Fgithub.com% > 2Fapache%2Fcordova-ios%234.5.3&data=02%7C01%7C% > 7Ce084f1f69b0e4617a32808d51bf87b7b%7Cfa7b1b5a7b34438794aed2c178de > cee1%7C0%7C0%7C636445676415459887&sdata=GLcgo4T%2BpcK96f8Rc1B4XgQ4K6R% > 2BPmt1stqGE7j7kyQ%3D&reserved=0 > > > >Upon a successful vote I will upload the archive to dist/, publish it to > >npm, and post the blog post. > > > >Voting guidelines: > >https://na01.safelinks.protection.outlook.com/?url= > https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs% > 2Frelease-voting.md&data=02%7C01%7C%7Ce084f1f69b0e4617a32808d51bf87b7b% > 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636445676415459887&sdata=waC% > 2BUz3DxUEVsUMNhyTIN7tli54QzIxX7lcMu%2F2vB6k%3D&reserved=0 > > > >Voting will go on for a minimum of 48 hours. > > > >I vote +1: > >* Ran coho audit-license-headers > >* Ran coho check-license > >* Ensured continuous build was green when repo was tagged > >* Created and tested against mobilespec > >* Created helloworld using CLI and build scripts, deployed to > >device/emulator >