I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Created hello world app & was able to add/ rm, build/run successfully to emulator * Npm test (passed)
On 11/8/17, 1:50 PM, "Suraj Pindoria" <pindoria.su...@gmail.com> wrote: >I vote +1: > >* Ran npm test, all greens >* Created hello-world and successfully deployed to emulator and device > >On Mon, Nov 6, 2017 at 3:44 PM, Joe Bowser <bows...@gmail.com> wrote: > >> Please review and vote on this 6.4.0 Android Release >> >> by replying to this email (and keep discussion on the DISCUSS thread) >> >> Release issue: >> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB-15328&data=02%7C01%7C%7C7ef3146720f64801841808d526f2cf99%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636457746667246255&sdata=KdNZwan2KSTZyr7h4FWDFjay%2BMXZFiSVBRmY7gTigHs%3D&reserved=0 >> >> The archive has been published to dist/dev: >> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Fcordova%2FCB-15328&data=02%7C01%7C%7C7ef3146720f64801841808d526f2cf99%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636457746667246255&sdata=cdg1bNexFkAsm8z6pbiLcFXVbxT8hWOIi27UNW7t2u0%3D&reserved=0 >> >> The package was published from its corresponding git tag: >> cordova-android: 6.4.0 (7a27ee4f69) >> >> Note that you can test it out via: >> >> cordova platform add >> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-android%236.4.0&data=02%7C01%7C%7C7ef3146720f64801841808d526f2cf99%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636457746667246255&sdata=V4eSZvvNwyCt7VnF3oGcPdJfNHfH1Am86tiFkc3fYcE%3D&reserved=0 >> >> Upon a successful vote I will upload the archive to dist/, publish it to >> npm, and post the blog post. >> >> Voting guidelines: >> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs%2Frelease-voting.md&data=02%7C01%7C%7C7ef3146720f64801841808d526f2cf99%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636457746667246255&sdata=pWKuOK95S2kEwumzjqU1jRxkQ3IjpOznjO3QghcB0Xg%3D&reserved=0 >> >> Voting will go on for a minimum of 48 hours. >> >> I vote +1: >> * Ran coho audit-license-headers over the relevant repos >> * Ran coho check-license to ensure all dependencies and subdependencies >> have Apache-compatible licenses >> * Ensured continuous build was green when repo was tagged >>
