I vote +1: * Created helloworld using CLI and build scripts, deployed to emulator * Ran npm test,(passed)
* Ran coho audit-license-headers * Ran coho check-license On 11/15/17, 2:27 PM, "Suraj Pindoria" <pindoria.su...@gmail.com> wrote: >Please review and vote on this 4.5.4 iOS Release by replying to this email >(and keep discussion on the DISCUSS thread) > >Release issue: >https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB-13579&data=02%7C01%7C%7C8fdb37ead9994ab746d208d52c79283d%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636463821230294178&sdata=nc7tIwg5LB3o6rr1l97kUeCQYJ04uMDorvHy%2F1xQnrM%3D&reserved=0 > >The archive has been published to dist/dev: >https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Fcordova%2FCB-13579&data=02%7C01%7C%7C8fdb37ead9994ab746d208d52c79283d%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636463821230294178&sdata=bq36tF0a%2F4KRvNYVMmcoscx6o3N3bjAGID7wIEuNiYQ%3D&reserved=0 > >The package was published from its corresponding git tag: > cordova-ios: 4.5.4 (acf91073e5) > >Note that you can test it out via: > > cordova platform add > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-ios%234.5.4&data=02%7C01%7C%7C8fdb37ead9994ab746d208d52c79283d%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636463821230294178&sdata=Y%2Ft7rngdixUYGoORWOXTHcmm8PTiVrurRpZmxvvVC20%3D&reserved=0 > >Upon a successful vote I will upload the archive to dist/, publish it to >npm, and post the blog post. > >Voting guidelines: >https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs%2Frelease-voting.md&data=02%7C01%7C%7C8fdb37ead9994ab746d208d52c79283d%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636463821230294178&sdata=vRXhzzoqt1LDibsMZJrb%2FjWqjRilnBx2Oa8zvhBJAeA%3D&reserved=0 > >Voting will go on for a minimum of 48 hours. > >I vote +1: >* Ran coho audit-license-headers >* Ran coho check-license >* Ensured continuous build was green when repo was tagged >* Created and tested against mobilespec >* Created helloworld using CLI and build scripts, deployed to >device/emulator
