I vote +1: - Ran npm test - Ran coho audit-license-headers - Ran coho check-license - Ran through https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md#test
On Fri, Dec 15, 2017 at 1:48 PM, Audrey So <a...@adobe.com.invalid> wrote: > > I vote +1: > * Ran npm test over relevant repos > * Ran coho audit-license-headers over the relevant repos > * Ran coho check-license to ensure all dependencies and > subdependencies have Apache-compatible licenses > > > > > > > > On 12/14/17, 1:51 PM, "Steven Gill" <stevengil...@gmail.com> wrote: > > >Please review and vote on this Tools Release > >by replying to this email (and keep discussion on the DISCUSS thread) > > > >Release issue: https://na01.safelinks.protection.outlook.com/?url= > https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB- > 13674&data=02%7C01%7Causo%40adobe.com%7Ceeee905aefe54cabf43808d5433ceddd% > 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636488851324261584&sdata= > mzyCPCbmkUTXSa4gTdWU3%2BmD9mNFZoeKhzK6vb3UA3E%3D&reserved=0 > >Both tools have been published to > >dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13674/ > > > >The packages were published from their corresponding git tags: > > > > cordova-lib: 8.0.0 (81f0a8214a) > > cordova-plugman: 2.0.0 (9224753804) > > cordova-cli: 8.0.0 (0aacb29a6e) > > cordova-fetch: 1.3.0 (5c57f09e75) > > cordova-common: 2.2.1 (3bdc82251e) > > cordova-create: 1.1.2 (64f1385d69) > > > >Upon a successful vote I will upload the archives to dist/, publish > >them to npm, and post the corresponding blog post. > > > >Voting guidelines: > >https://na01.safelinks.protection.outlook.com/?url= > https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs% > 2Frelease-voting.md&data=02%7C01%7Causo%40adobe.com% > 7Ceeee905aefe54cabf43808d5433ceddd%7Cfa7b1b5a7b34438794aed2c178de > cee1%7C0%7C0%7C636488851324261584&sdata=aQv747TQWJ1WqDN% > 2FEQYDDh0TVrxidSTCZgW%2BIin2OmA%3D&reserved=0 > > > >Voting will go on for a minimum of 48 hours. > > > >I vote +1: > >* Ran coho audit-license-headers over the relevant repos > >* Ran coho check-license to ensure all dependencies and > >subdependencies have Apache-compatible licenses > >* Ensured continuous build was green when repos were tagged > >* Ran through testing section at > >https://na01.safelinks.protection.outlook.com/?url= > https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs% > 2Ftools-release-process.md%23test&data=02%7C01%7Causo%40adobe.com% > 7Ceeee905aefe54cabf43808d5433ceddd%7Cfa7b1b5a7b34438794aed2c178de > cee1%7C0%7C0%7C636488851324261584&sdata=FQcJKpgyRGrffvKRkeFs%2Byt% > 2BN8KLPvZ2Icwo6Ym43RU%3D&reserved=0 >
