The vote has now closed. I would like to thank Jesse MacFadyen and Shazron Abdullah for taking the time to review and vote. The results are:
Positive Binding Votes: 3 - Jesse MacFadyen - Shazron Abdullah - Christopher Brody Negative Binding Votes: 0 The vote has passed. On Fri, Jun 29, 2018 at 10:37 PM Shazron <[email protected]> wrote: > > +1 > > On Sat, Jun 30, 2018 at 10:23 AM Jesse <[email protected]> wrote: > > > I vote +1 > > > > * [+] no known vulnerabilities found [440 packages audited] > > * ran tests at tagged commit 2.2.5 > > * Ran coho audit-license-headers > > * Ran coho check-license > > * Ran coho verify-archive on release artifacts > > * Ensured continuous build was green when repos were tagged > > > > > > > > @purplecabbage > > risingj.com > > > > On Tue, Jun 26, 2018 at 6:57 PM, Chris Brody <[email protected]> > > wrote: > > > > > Please review and vote on this cordova-common 2.2.5 (patch release) by > > > replying to this email (and keep discussion on the [DISCUSS] thread) > > > > > > Release issue: https://issues.apache.org/jira/browse/CB-14174 > > > > > > Purpose is to resolve npm audit issues without generating ugly engine > > > warning messages on deprecated Node.js 4 version, as needed by > > > cordova-android, cordova-ios, and additional tools and platform > > > packages. > > > > > > Artifacts for this cordova-common patch release have been published > > > to: https://dist.apache.org/repos/dist/dev/cordova/CB-14174/ > > > > > > The package artifacts were published from their corresponding git tag(s): > > > > > > cordova-common: 2.2.5 (a77a1ed939) > > > > > > Upon a successful vote I will upload the archives to dist/, publish > > > them to npm, and post the corresponding blog post. > > > > > > Voting guidelines: > > > > > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > > > > > Voting will go on for a minimum of 48 hours. > > > > > > I vote +1: > > > * Ran coho audit-license-headers over the relevant repos > > > * Ran coho check-license to ensure all dependencies and > > > sub-dependencies have Apache-compatible licenses > > > * Ensured continuous build was green when repos were tagged > > > > > > Thanks and best regards, > > > > > > Chris > > > > > > https://twitter.com/brodybits > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: [email protected] > > > For additional commands, e-mail: [email protected] > > > > > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
