Thanks Jesse for the review and vote. I already raised CB-14205 (<https://issues.apache.org/jira/browse/CB-14205>) in response to Shazron's observation. Does it cover your observation or should I maybe raise another issue? On Mon, Jul 16, 2018 at 5:13 AM Jesse <purplecabb...@gmail.com> wrote: > > I voted +1 because I don't think the issues I encountered will affect > regular users. > > The CI is green, BUT it has errors, that it deems not enough to reject ... > I think it should > Here is the 'green' CI with apparent fatal errors in the log: > https://travis-ci.org/apache/cordova-android/builds/402927106 > > My error was similar to Shazron's: > ----- > * What went wrong: > A problem occurred configuring project ':app'. > > SDK location not found. Define location with sdk.dir in the > local.properties file or with an ANDROID_HOME environment variable. > * Try: > Run with --stacktrace option to get the stack trace. Run with --info or > --debug option to get more log output. Run with --scan to get full insights. > > * Get more help at https://help.gradle.org > at ChildProcess.whenDone > (/Repos/cordova/cordova-android/node_modules/cordova-common/src/superspawn.js:169:23) > at emitTwo (events.js:126:13) > at ChildProcess.emit (events.js:214:7) > at maybeClose (internal/child_process.js:925:16) > at Process.ChildProcess._handle.onexit (internal/child_process.js:209:5) > stderr: '\nFAILURE: Build failed with an exception.\n\n* What went > wrong:\nA problem occurred configuring project \':app\'.\n> SDK location > not found. Define location with sdk.dir in the local.properties file or > with an ANDROID_HOME environment variable.\n\n* Try:\nRun with --stacktrace > option to get the stack trace. Run with --info or --debug option to get > more log output. Run with --scan to get full insights.\n\n* Get more help > at https://help.gradle.org\n', > stdout: '\nBUILD FAILED in 0s\n', > code: 1 } > Tests completed successfully. > ----- > > > Also, a minor thing ... I depend on all [VOTE] threads containing the word > [VOTE], this one did not, so I did not immediately see it. I am somewhat > dependent on my filters ... > > > > @purplecabbage > risingj.com > > On Sun, Jul 15, 2018 at 11:14 PM, Shazron <shaz...@gmail.com> wrote: > > > Need one more vote for Cordova-Android to wrap it up. > > On Thu, Jul 12, 2018 at 7:49 PM Chris Brody <chris.br...@gmail.com> wrote: > > > > > > Thanks Shazron for reviewing. I just raised CB-14205 > > > <https://issues.apache.org/jira/browse/CB-14205> to add hints and help > > > links to error messages. > > > > > > On Jul 12, 2018 1:57 AM, "Shazron" <shaz...@gmail.com> wrote: > > > > > > I realize that and that's what I did -- the error message was not > > > helpful because I thought it would just detect the one in Android > > > Studio (seems to be specific to Windows?). > > > > > > Another gotcha: I had to add $ANDROID_HOME/emulator to my PATH to run > > > it in the emulator > > > On Thu, Jul 12, 2018 at 1:50 PM Darryl Pogue <dar...@dpogue.ca> wrote: > > > > > > > > I believe on macOS you'll need to install gradle through something > > > > like Homebrew. > > > > > > > > On Wed, Jul 11, 2018 at 10:42 PM Shazron <shaz...@gmail.com> wrote: > > > > > > > > > > Sorry, Android newbie here. > > > > > > > > > > I have Android 3.1.3 installed on macOS, with cordova 8.0.0. > > > > > I did: > > > > > cordova platform add https://github.com/apache/ > > cordova-android#7.1.1 > > > > > cordova build > > > > > > > > > > I get this error: > > > > > > > > https://github.com/apache/cordova-android/blob/ > > bf29fe0e10334938d2e6ee8116f9a30c762c40b4/bin/templates/ > > cordova/lib/check_reqs.js#L137 > > > > > > > > > > Should it be able to detect and use the gradle within Android > > > Studio.app? > > > > > > > > > > Based on code inspection here, it doesn't (isWindows is false, and > > > > > thus androidStudioPath is also null): > > > > > > > > https://github.com/apache/cordova-android/blob/ > > bf29fe0e10334938d2e6ee8116f9a30c762c40b4/bin/templates/ > > cordova/lib/check_reqs.js#L122 > > > > > > > > > > I know the docs say "As of Cordova-Android 6.4.0, Gradle is now > > > > > required to be installed to build Android." so perhaps the error > > > > > message needs to be tweaked. > > > > > > > > > > ------------------------------------------------------------ > > --------- > > > > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > > > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > >
--------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
