Thanks Julio. Considering that this is a *patch* release, issued to resolve a few issues, I would really favor a quick review from a couple cordova-windows experts to ensure that I didn't break anything major.
Changes are from the following PRs: * https://github.com/apache/cordova-windows/pull/287 * https://github.com/apache/cordova-windows/pull/285 * https://github.com/apache/cordova-windows/pull/281 On Sun, Sep 16, 2018 at 6:55 PM julio cesar sanchez <jcesarmob...@gmail.com> wrote: > > Just a reminder that any discussion about a release should be done on the > discuss thread and not on the vote thread, even if the comment is to try to > get more votes for that release. Vote threads should only be used to vote, > and close the vote once it reaches the minimum number of votes. > > So Brody still needs some votes for this release. > > Looks like some of you had some troubles testing, that could be -1 votes if > you think something is not right. > > > > > > El jue., 16 ago. 2018 a las 10:59, Shazron (<shaz...@gmail.com>) escribió: > > > I'm still investigating this splashscreen issue -- not sure if > > something broke, or I haven't defined something > > (am n00b on Windows platform...) > > On Wed, Aug 15, 2018 at 4:19 PM Jan Piotrowski <piotrow...@gmail.com> > > wrote: > > > > > > > I had to set the MSBUILDDIR env var explicitly to C:\Program Files > > > > (x86)\Microsoft Visual Studio\2017\Community\MSBuild\15.0\Bin since > > > > our code fails to detect the MSBuild version installed with that, > > > > v15.8. > > > > > > > > The registry entry it checks still has MSBuild v4 from the .NET > > > > Framework -- so perhaps our detection is outdated. > > > > > > From what I remember our MSBuild detection logic is a bit more > > > complicated and does many, many things to find it. > > > My best guess here is that somewhere `15.8` would have to be added to > > > a list - when cordova-windows 6.0.0 was released the correct MSBuild > > > was autodetected. > > > Should probably be rewritten completely :/ > > > > > > > I had also noticed this issue, with Visual Studio 2017, from our > > AppVeyor tests. > > > > The AppVeyor configuration is set to accept the failures as a passing > > result if using Visual Studio 2017. > > > > I had been wanting to fix this so the tests would actually run and > > pass properly but didn’t have too much time to look into this. > > > > > > AppVeyor fails for Visual Studio 2017 because of one unexplained test > > > failure, that only happens on CI. > > > (I thought there already was an issue, seems I was wrong. Created > > > https://github.com/apache/cordova-windows/issues/290). > > > > > > J > > > > > > 2018-08-15 8:16 GMT+02:00 Bryan Ellis <ellis.br...@gmail.com>: > > > > I had also noticed this issue, with Visual Studio 2017, from our > > AppVeyor tests. > > > > > > > > > > https://ci.appveyor.com/project/Humbedooh/cordova-windows/build/1.0.1020 > > > > > > > > The AppVeyor configuration is set to accept the failures as a passing > > result if using Visual Studio 2017. > > > > > > > > I had been wanting to fix this so the tests would actually run and > > pass properly but didn’t have too much time to look into this. > > > > > > > > > > > >> On Aug 15, 2018, at 14:54, Shazron <shaz...@gmail.com> wrote: > > > >> > > > >> https://github.com/apache/cordova-windows/issues/274 which is not a > > > >> blocker IMO, but I'm not sure of the splash screen. Technically the > > > >> app builds and runs... > > > >> On Wed, Aug 15, 2018 at 1:40 PM Shazron <shaz...@gmail.com> wrote: > > > >>> > > > >>> You can debug what requirements it tries to detect for MSBUILD by > > running: > > > >>> cordova requirements --verbose > > > >>> On Wed, Aug 15, 2018 at 1:39 PM Shazron <shaz...@gmail.com> wrote: > > > >>>> > > > >>>> Repro steps: > > > >>>> > > > >>>> ``` > > > >>>> npm install -g cordova > > > >>>> cordova create foo > > > >>>> cd foo > > > >>>> cordova platform add > > https://github.com/apache/cordova-windows#6.0.1 > > > >>>> cordova run > > > >>>> ``` > > > >>>> > > > >>>> Pre-requisites: > > > >>>> - Visual Studio 2017 Community installed with defaults > > > >>>> - Windows 10 SDK > > > >>>> - Set env var `MSBUILDDIR` to 'C:\Program Files > > > >>>> (x86)\Microsoft Visual Studio\2017\Community\MSBuild\15.0\Bin' > > > >>>> > > > >>>> On Wed, Aug 15, 2018 at 1:36 PM Shazron <shaz...@gmail.com> wrote: > > > >>>>> > > > >>>>> Had trouble meeting the requirements to build, using VS 2017 > > Community edition > > > >>>>> I had to set the MSBUILDDIR env var explicitly to C:\Program Files > > > >>>>> (x86)\Microsoft Visual Studio\2017\Community\MSBuild\15.0\Bin since > > > >>>>> our code fails to detect the MSBuild version installed with that, > > > >>>>> v15.8. > > > >>>>> > > > >>>>> The registry entry it checks still has MSBuild v4 from the .NET > > > >>>>> Framework -- so perhaps our detection is outdated. > > > >>>>> > > > >>>>> After I added the env var, I could `cordova build`. > > > >>>>> `cordova run` guided me to change some settings and run in elevated > > > >>>>> permissions, and I ran `cordova run` again. > > > >>>>> > > > >>>>> The app launches, and I get a 'broken image` icon for the splash > > > >>>>> screen. Is this a known issue? > > > >> > > > >> --------------------------------------------------------------------- > > > >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > > >> For additional commands, e-mail: dev-h...@cordova.apache.org > > > >> > > > > > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
