I vote +1: - Ran `coho verify-tags -g` with the tag string from above - Confirmed sigs & hashes with `coho verify-archive` - Checked that the changes in the 8.1.x branch should do what the "release issue" and changelog says - Checked out 8.1.x branch and successfully ran `npm t` (and observed 1 failure from a flaky-on-Windows test) - Checked that CI is green - Ran `npm install` on the extracted package, observed `xcode` being installed Am Mo., 1. Okt. 2018 um 20:08 Uhr schrieb Chris Brody <[email protected]>: > > Please review and vote on this tools patch release by replying to this > email (and keep discussion on the DISCUSS thread) > > Release issue: https://github.com/apache/cordova-lib/issues/706 > > Distribution files have been published to dist/dev: > https://dist.apache.org/repos/dist/dev/cordova/GH-706/ > > The packages were published from their corresponding git tags: > > cordova-lib: 8.1.1 (54858f8892) > > Upon a successful vote I will upload the archives to dist/, publish > them to npm, and post the corresponding blog post. > > Voting guidelines: > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > Voting will go on for a minimum of 48 hours. > > I vote +1: > * Ran coho audit-license-headers over the relevant repos > * Ran coho check-license to ensure all dependencies and > subdependencies have Apache-compatible licenses > * Ensured continuous build was green when repos were tagged > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] >
--------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
