+1 * CI is green * coho verify-archive cordova-common-3.2.0.tgz ✅ * coho check-license ✅ * Changes make sense
PS @Chris - it seems your GPG key is not (yet) in the https://people.apache.org/keys/group/cordova.asc list. Given my account Apache account is very new, but my key is in the list, I assume you need to add it to https://id.apache.org :) On Wed, Jun 12, 2019 at 10:12 PM <raphine...@gmail.com> wrote: > +1 > > Reviewed changes since last version > > Am Mi., 12. Juni 2019 um 11:19 Uhr schrieb Jan Piotrowski < > piotrow...@gmail.com>: > > > +1 > > > > Changes since 3.1.0 look good. > > > > (Waiting for CI to turn green on release commit though.) > > > > Am Mi., 12. Juni 2019 um 10:59 Uhr schrieb Chris Brody < > > chris.br...@gmail.com>: > > > > > Please review and vote on this cordova-common@3.2.0 tools release by > > > replying to this email (and keep discussion on the DISCUSS thread). > > > > > > cordova-common@3.2.0 tools release artifacts have been published to > > > dist/dev: > > > https://dist.apache.org/repos/dist/dev/cordova/cordova-common-3.2.0/ > > > > > > The packages were published from their corresponding git tags: > > > > > > cordova-common: 3.2.0 (68014753da) > > > > > > Blog post is already proposed in: > > > https://github.com/apache/cordova-docs/pull/1002 > > > > > > Upon a successful vote I will upload the archives to dist/, publish > > > them to npm, and post the corresponding blog post. > > > > > > Voting guidelines: > > > > > > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > > > > > Voting will go on for a minimum of 48 hours. > > > > > > I vote +1: > > > * Ran coho audit-license-headers over the relevant repos > > > * Ran coho check-license to ensure all dependencies and > > > subdependencies have Apache-compatible licenses > > > * Ensured continuous build was green when repos were tagged > > > * npm audit shows no warning messages > > > * I raised PRs including some DRAFT PRs for outdated packages that > > > were indicated by: npm outdated > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > > > > > > -- Tim Brust, Product Engineer tim.br...@sinnerschrader.com T +49 40 398855 315 SinnerSchrader Deutschland GmbH | SinnerSchrader Group Völckersstraße 38, 22765 Hamburg, Germany Amtsgericht Hamburg HRB-Nr. 63663 Geschäftsführer: Matthias Schrader (Sprecher), Jürgen Alker, Dr. Axel Averdung, Holger Blank, Thomas Dyckhoff, Dr. Lars Finke, Martin Gassner, Peggy Hutchinson Büros: Berlin, Hamburg, Frankfurt a. M., München, Prag https://www.sinnerschrader.com | NEXT AGENCY
