+1 - CI is green - Changes make sense - I could successfully build an app with it
Am Fr., 28. Juni 2019 um 15:25 Uhr schrieb Tim Brust <timbrust3...@gmail.com>: > > I vote +1: > * CI is green for release tag > * coho verify-archive ✅ > * coho check-license ✅ > * npm audit ✅ > * npm test ✅ > > On Fri, Jun 28, 2019 at 6:17 AM Bryan Ellis <er...@apache.org> wrote: > > > Please review and vote on this Electron Release v1.1.0 > > by replying to this email (and keep discussion on the DISCUSS thread) > > > > The archive has been published to dist/dev: > > https://dist.apache.org/repos/dist/dev/cordova/electron-v1.1.0 > > > > The package was published from its corresponding git tag: > > cordova-electron: 1.1.0 (32dd1c40dc) > > > > > > Note that you can test it out via: > > > > cordova platform add https://github.com/apache/cordova-electron#1.1.0 > > > > Upon a successful vote I will upload the archive to dist/, publish it to > > npm, and post the blog post. > > > > Voting guidelines: > > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > > > Voting will go on for a minimum of 48 hours. > > > > I vote +1: > > * Ran coho audit-license-headers over the relevant repos > > * Ran coho check-license to ensure all dependencies and subdependencies > > have Apache-compatible licenses > > * Ensured continuous build was green when repo was tagged > > * NPM Audit > > * NPM Test > > > > > -- > Tim Brust > timbrust3...@gmail.com > > M: +49 160 9757 3632 <+4916097573632> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
