erisu commented on a change in pull request #1: chore: added missing package
repo & bug field
URL: https://github.com/apache/cordova-eslint/pull/1#discussion_r342898975
##########
File path: package.json
##########
@@ -6,6 +6,13 @@
"scripts": {
"test": "eslint ."
},
+ "repository": {
+ "type": "git",
+ "url": "https://github.com/apache/cordova-eslint";
+ },
Review comment:
I decided to use `"repository": "github:apache/cordova-eslint",`.
Even though `"repository": "apache/cordova-eslint",` looks cleaner, there
are concerns on how NPM handle which source is displayed when there are
multiple sources exist.
* What if today GH is displayed first due to ordering but in the future they
decided another service is displayed first.
* What if there are multiple source, does npm display both?
* If multiple sources exist and displayed, what if one is just a spoof repo
that we dont have control?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
