I vote +1

ran npm test
ran npm audit
created an app with the new preference and ran it without problems

El sáb., 30 nov. 2019 a las 17:47, Jesse (<purplecabb...@gmail.com>)
escribió:

> +1
>
> - ci is green
> - coho verify-archive
> - ran tests locally, npm audit
>
> On Thu, Nov 28, 2019 at 11:46 PM Niklas Merz <nm...@gedys-intraware.de>
> wrote:
>
> > I vote +1 (non-binding)
> > * CI is greeen for tag
> > * Confirmed sigs & hashes with `coho verify-archive` [1]
> > * Verified sha1s match tags with `coho@nightly verify-tags`
> > * Created a new cordova project, added the platform and launched
> > successfully on iPhone
> >
> > ----- Ursprüngliche Nachricht -----
> > Von: "Bryan Ellis" <er...@apache.org>
> > An: dev@cordova.apache.org
> > CC:
> > Betreff: [VOTE] Cordova-iOS 5.1.1 Release
> > Datum: Do, 28. Nov 2019 18:25
> >
> > Please review and vote on this iOS Release v5.1.1
> > by replying to this email (and keep discussion on the DISCUSS thread)
> >
> > The archive has been published to dist/dev:
> > https://dist.apache.org/repos/dist/dev/cordova/ios-v5.1.1
> >
> > The package was published from its corresponding git tag:
> >     cordova-ios: 5.1.1 (86a87fed74)
> >
> > Note that you can test it out via:
> >
> >     cordova platform add https://github.com/apache/cordova-ios#5.1.1
> >
> > Upon a successful vote I will upload the archive to dist/, publish it to
> > npm, and post the blog post.
> >
> > Voting guidelines:
> >
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
> >
> > Voting will go on for a minimum of 48 hours.
> >
> > I vote +1:
> > * Ran coho audit-license-headers over the relevant repos
> > * Ran coho check-license to ensure all dependencies and subdependencies
> > have Apache-compatible licenses
> > * Ensured continuous build was green when repo was tagged
> > * NPM Audit
> > * NPM Tests
> > * Build Tests
> >
> >
> > Sitz der Gesellschaft: GEDYS IntraWare GmbH, Brückenmühle 93, 36100
> > Petersberg, Deutschland
> > Tel.: +49 661 9642-0 | Fax: +49 661 9642-99 | i...@gedys-intraware.de |
> > www.gedys-intraware.de
> > Registereintragung: Amtsgericht Fulda HRB 5156 | Ust.-ID: DE 188 682 194
> > gemäß Paragraph 27a UstG  | Geschäftsführung: Joachim Weber, Ralf
> > Geishauser, Frank Hohl
> > AGB | Impressum | Datenschutzbestimmungen
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >
>

Reply via email to