I am closing this VOTE with -1 due to some issues discovered by Bryan Ellis:
- VERSION file still with -dev - template/cordova/version file with -defv - updates to cordova-js-src not included in cordova.js On Wed, Dec 18, 2019 at 2:35 PM Jesse <purplecabb...@gmail.com> wrote: > +1 > > - coho verify-archive > - CI is green > - reviewed changes > > On Sun, Dec 15, 2019 at 7:12 PM Chris Brody <chris.br...@gmail.com> wrote: > > > Please review and vote on this cordova-windows@7.1.0 release by > > replying to this email (and keep discussion on the DISCUSS thread) > > > > The archive has been published to dist/dev: > > https://dist.apache.org/repos/dist/dev/cordova/cordova-windows-7.1.0/ > > > > The package was published from its corresponding git tag: > > cordova-windows: 7.1.0 (e5b28f2784) > > > > Note that you can test it out via: > > > > cordova platform add https://github.com/apache/cordova-windows#7.1.0 > > > > Upon a successful vote I will upload the archive to dist/, publish it > > to npm, and post the blog post. > > > > Voting guidelines: > > > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > > > Voting will go on for a minimum of 48 hours. > > > > I vote +1: > > * Ran coho audit-license-headers over the relevant repos > > * Ran coho check-license to ensure all dependencies and > > subdependencies have Apache-compatible licenses > > * Ensured continuous build was green when repo was tagged > > * Tested with cordova-sqlite-storage@4.0.0 > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > >
