I vote -1 Unfortunately I decided to vote -1. This does not block this release immediately since 3 +1 votes are still a majority.
I don't know this package or the history of it but as far as I know every Apache release MUST have a LICENSE and NOTICE file [1]. I cannot find these in the repo and package. Correct me if I am wrong. Successfully checked * Confirmed sigs & hashes with `coho verify-archive` * Verified sha1s match tags with `coho verify-tags` * CI is green * run 'npm install' in package * tests success on local [1] http://www.apache.org/legal/release-policy.html#licensing April 7, 2020 6:48 PM, "Bryan Ellis" <er...@apache.org> wrote: > Please review and vote on this Cordova Fetch Major Release v3.0.0 > by replying to this email (and keep discussion on the DISCUSS thread) > > The archive has been published to dist/dev: > https://dist.apache.org/repos/dist/dev/cordova/fetch-3.0.0 > > The package was published from its corresponding git tag: > cordova-fetch: 3.0.0 (392cb1ef35) > > Upon a successful vote I will upload the archive to dist/, publish it to > npm, and post the blog post. > > Voting guidelines: > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > Voting will go on for a minimum of 48 hours. > > I vote +1: > * Ran coho audit-license-headers over the relevant repos > * Ran coho check-license to ensure all dependencies and subdependencies > have Apache-compatible licenses > * Ensured continuous build was green when repo was tagged > * NPM Audit > * NPM Test --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
