Then I will start the release process without further changes or PRs merged this evening (in about 12 hours).
> While it would be ideal to get this fixed, ideally by migrating to GitHub actions, probably not worth holding up the release. Good point. Let's get this release out and fix CI properly after that. Travis CI was enough pain while testing this and Github Actions work much better. June 8, 2020 2:14 PM, "Chris Brody" <chris.br...@gmail.com> wrote: > To be clear, I would definitely not favor blocking this release. Thanks > again. > > On Mon, Jun 8, 2020 at 8:12 AM Chris Brody <chris.br...@gmail.com> wrote: > >> While it would be ideal to get this fixed, ideally by migrating to GitHub >> actions, probably not worth holding up the release. >> >> Thanks for your work on this. >> >> On Mon, Jun 8, 2020 at 3:19 AM Niklas Merz <niklasm...@apache.org> wrote: >> >>> The master branch is now ready for release. >>> >>> While trying to get another PR in, I noticed that Travis CI is using an >>> old version of cordova-ios (5.1.1) and Xcode 10. I tried to update that >>> with partial success: >>> https://github.com/apache/cordova-plugin-inappbrowser/pull/717 Has >>> anybody an idea how to fix that? >>> >>> Do you think we should do the upgrade for CI make sure it tests with the >>> current iOS versions or release it as it is now because people are >>> waiting urgently for that version? >>> >>> Am 02.06.20 um 20:31 schrieb Niklas Merz: >>>> Hi all, >>>> >>>> since cordova-ios 6.0 was released recently the inappbrowser plugin >>> does not work properly because of the removal of UIWebView. I would >>> suggest we do a plugin *release as soon as possible*. >>>> >>>> Since we already merged some major changes (including the UIWebview >>> removal) this will be a major release. >>>> >>>> Does anyone have a reason to delay the release? >>>> >>>> From my personal use of the plugin to pending PRs would be helpfull >>> for this release, but they need reviews. I would not delay the release >>> for them and proceed without merging them. >>>> https://github.com/apache/cordova-plugin-inappbrowser/pull/688 >>>> https://github.com/apache/cordova-plugin-inappbrowser/pull/656 >>>> >>>> Any other outstanding patches to land? >>>> >>>> If not, I will start the release tomorrow. >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >>>> For additional commands, e-mail: dev-h...@cordova.apache.org >>>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >>> For additional commands, e-mail: dev-h...@cordova.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
