I vote +1

- CI is green
- changes make sense
- npm audit is happy
- coho verify-archive is happy

Thanks Darryl for making the release!

On Sat, Aug 29, 2020 at 9:01 AM Niklas Merz <niklasm...@apache.org> wrote:

> I vote +1
>
> * verified tag and hash
> * no audit issues
> * draft tag matches sha in email (checked manually)
> * checked LICENSE + NOTICE
> * CI green
> * changes look good
>
>
>
> One minor issue: coho verify-tags does not work with new "draft" naming
>
>
> Am 28.08.20 um 23:31 schrieb Darryl Pogue:
> > Hi folks,
> > Apologies for the delay in getting this release together!
> >
> > Please review and vote on this 6.1.1 Cordova-iOS release by replying
> > to this email (and keep discussion on the DISCUSS thread)
> >
> > The archive has been published to dist/dev:
> > https://dist.apache.org/repos/dist/dev/cordova/ios611/
> >
> > The package was published from its corresponding git tag (draft/6.1.1):
> > cordova-ios: 6.1.1 (3ba64485f3)
> >
> > Note that you can test it out via:
> > cordova platform add github:apache/cordova-ios#draft/6.1.1
> >
> > Upon a successful vote I will upload the archive to dist/, publish it
> > to npm, and post the blog post.
> >
> > Voting guidelines:
> >
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
> >
> > Voting will go on for a minimum of 48 hours.
> >
> > I vote +1:
> > * Updated dependencies and verified no npm audit warnings
> > * Ran npm tests locally and confirmed passing
> > * Ran coho audit-license-headers over the relevant repos
> > * Ran coho check-license to ensure all dependencies and
> > subdependencies have Apache-compatible licenses
> > * Ensured continuous build was green when repo was tagged
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

-- 
Tim Brust
timbrust3...@gmail.com

M: +49 160 9757 3632 <+4916097573632>

Reply via email to