I vote +1 - Checked hash and signature - npm audit - Checked license headers - Checked tag - Ran new project
On September 2, 2021, Norman Breau <nor...@nbsolutions.ca> wrote: > I vote +1: > - Ran npm audit (0 vulns found) > - Ran npm test locally successfully (linux/Ubuntu 20) > - Created a project and built/ran successfully (Linux/Ubuntu 20) > - verified tags > - verified archive > > On 2021-09-01 1:17 a.m., Bryan Ellis wrote: > > Please review and vote on this Electron Release v3.0.0 > > by replying to this email (and keep discussion on the DISCUSS > thread) > > > > The archive has been published to dist/dev: > > https://dist.apache.org/repos/dist/dev/cordova/electron-v3.0.0 > > > > > > The package was published from its corresponding git tag: > > > > > > > > Note that you can test it out via: > > cordova platform add https://github.com/apache/cordova- > electron#3.0.0 > > > > > > Upon a successful vote I will upload the archive to dist/, publish > it to npm, and post the blog post. > > > > Voting guidelines: https://github.com/apache/cordova- > coho/blob/master/docs/release-voting.md > > > > Voting will go on for a minimum of 48 hours. > > > > ————— > > > > I vote +1: > > > > * Ran `coho audit-license-headers` over the relevant repos > > * Ran `coho check-license` to ensure all dependencies and sub- > dependencies have Apache-compatible licenses > > * Ensured the `npm audit` report was sufficient for release > > * Ensured continuous build was green when repo was tagged > > * Ran `npm test` > > * Ran following `cordova` test in sample project: > > * `cordova platform add cordova-electron-3.0.0.tgz` > > * `cordova plugin add` > > * `cordova build electron` > > * `cordova run electron --nobuild` > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org
