I vote -1

Just noticed the engines are not correctly set in the package.json and that
will prevent people from installing the plugin:

"3.0.0": {
    "cordova": ">100"
}

Will send a pull request fixing it as soon as github is back online.


El vie, 19 nov 2021 a las 17:09, Niklas Merz (<niklasm...@apache.org>)
escribió:

> I vote +1
>
> I did:
> * hash & signature check
> * checked tag
> * quick test on ios
> * checked licenses and headers
> * npm audit
>
> On November 19, 2021, Erisu <er...@apache.org> wrote:
> > Please review and vote on this Cordova Plugin Statusbar Release v3.0.0
> > by replying to this email (and keep discussion on the DISCUSS thread)
> >
> > The archive has been published to dist/dev:
> >
> >  https://dist.apache.org/repos/dist/dev/cordova/statusbar-v3.0.0
> >
> > The package was published from its corresponding git tag:
> >
> >  cordova-plugin-statusbar: 3.0.0 (d95cc821fc)
> >
> > Upon a successful vote I will upload the archive to dist/, publish it
> > to npm, and post the blog post.
> >
> > Voting guidelines: https://github.com/apache/cordova-
> > coho/blob/master/docs/release-voting.md
> >
> > Voting will go on for a minimum of 48 hours.
> >
> > ====
> >
> > I vote +1:
> >
> > * Ran coho audit-license-headers over the relevant repos
> > * Ran coho check-license to ensure all dependencies and sub-
> > dependencies have Apache-compatible licenses
> > * Ensured the npm audit report was sufficient for release
> >
> > * AS there are issues within the CI testing service accross ALL
> > plugins, for this release I have manually tested:
> >  * Build Mobile Spec project for iOS & Android w/ CLI
> >  * Run Mobile Spec project on iOS & Android simulator w/ CLI
> >  * Executed the Mobile Spec Jasmine tests on iOS & Android
> >
> > Audit Report:
> >
> >  0 vulnerabilities found
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
>

Reply via email to