I vote +1:

- Verified archive
- Verified tags
- Test runs locally

On 2023-01-13 10:37 a.m., Niklas Merz wrote:
I vote +1

I checked:

* signature & hash ok
* installed cli version number correct
* cordova create
* cordova info
* cordova platform add
* tests pass locally
* only moderate audit issues (to be fixed in upcoming major release
12.0, PRs exist)
* license headers ok
* changes look good https://github.com/apache/cordova-
cli/compare/11.0.0...11.1.0

PLEASE NOTE: The correct download link is
https://dist.apache.org/repos/dist/dev/cordova/cli-11.1.0/


On January 11, 2023, Erisu <er...@apache.org> wrote:
Please review and vote on this cordova-cli release v11.1.0
by replying to this email (and keep discussion on the DISCUSS thread)

The archive has been published to dist/dev:
https://dist.apache.org/repos/dist/dev/cordova/lib-11.1.0

The package was published from its corresponding git tag:
  cordova-cli: 11.1.0 (934a0ff4b1)

Upon a successful vote I will upload the archive to dist/, publish it
to npm, and post the blog post.

Voting guidelines: https://github.com/apache/cordova-
coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

====

I vote +1:

* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and sub-
dependencies have Apache-compatible licenses
* Ensured the continuous build was green when repo was tagged
* Ran `npm test`

* Ran various `cordova` test w/ sample app:
  * `cordova`
  * `cordova -v`
  * `cordova create`
  * `cordova info`
  * `cordova help`
  * `cordova config ls`
  * `cordova requirements`
  * `cordova telemetry`
  * `cordova plugin`
  * `cordova plugin add`
  * `cordova plugin rm`
  * `cordova platform`
  * `cordova platform add`
  * `cordova platform rm`
  * `cordova build`
  * `cordova prepare`
  * `cordova compile`
  * `cordova run`
  * `cordova serve`

* Ran `npm audit`

---

16 vulnerabilities (12 low, 4 moderate)

Listed vulnerabilities are low to moderate and come from sub-sub
dependencies. Fixing should be handled in the sub packages.

In terms of issues that can be resolved in CLI will require and be
performed within the next major release.

—



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to