+1 * Confirmed sigs & hashes with `coho verify-archive` [1] * Verified sha1s match tags with `coho verify-tags` [2] * Re-created archives to ensure contents match release candidate [3] * Verified existence for required Apache files : NOTICE & LICENSE * Ran `npm cit` and confirm tests are passing
> On Sep 20, 2023, at 1:11, Niklas Merz <niklasm...@apache.org> wrote: > > I vote +1 > > * signature & hash ok > * npm audit green > * tag ok > * test ok locally > * changes look good > > On September 16, 2023, Norman Breau <nor...@nbsolutions.ca> wrote: >> Please review and vote on the release of this plugins release >> by replying to this email (and keep discussion on the DISCUSS thread) >> >> The plugins have been published to dist/dev: >> >> https://dist.apache.org/repos/dist/dev/cordova/cdv-plugin-geolocation- >> 5.0.0/ >> >> The packages were published from their corresponding git tags: >> cordova-plugin-geolocation: 5.0.0 (8f05b8d31a) >> >> Upon a successful vote I will upload the archives to dist/, upload >> them >> to npm, and post the corresponding blog post. >> >> Voting guidelines: >> https://github.com/apache/cordova-coho/blob/master/docs/release- >> voting.md >> How to vote on a plugins release at >> https://github.com/apache/cordova-coho/blob/master/docs/plugins- >> release-process.md#voting >> >> Voting will go on for a minimum of 48 hours. >> >> I vote +1: >> * Ran coho audit-license-headers over the relevant repos >> * Ran coho check-license to ensure all dependencies and >> subdependencies >> have Apache-compatible licenses >> * Ensured continuous build was green when repos were tagged >> - iOS fails because it hangs and times out on permission prompt, >> requires manual interaction. >> * Verified Archive >> * npm test >> * npm audit >> * Ran paramedic tests on Android successfully >> * Ran paramedic tests on iOS successfully >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >> For additional commands, e-mail: dev-h...@cordova.apache.org
