+1 - code review - built a new electron app
On Sat, Mar 9, 2024 at 3:00 AM Niklas Merz <niklasm...@apache.org> wrote: > I vote +1 > > * signature ok > * hash ok > * new app builds with this platform on my system > * tag ok > * tests pass locally > * changes look good > * licenses & headers look ok > > On March 5, 2024, Erisu <er...@apache.org> wrote: > > Please review and vote on this Electron Release v4.0.0 > > by replying to this email (and keep discussion on the DISCUSS thread) > > > > The archive has been published to dist/dev: > > https://dist.apache.org/repos/dist/dev/cordova/electron-v4.0.0 > > > > > > The package was published from its corresponding git tag: > > cordova-electron: 4.0.0 (d2192b20dc) > > > > > > Note that you can test it out via: > > cordova platform add https://github.com/apache/cordova-electron#4.0.0 > > > > > > Upon a successful vote I will upload the archive to dist/, publish it > > to npm, and post the blog post. > > > > Voting guidelines: https://github.com/apache/cordova- > > coho/blob/master/docs/release-voting.md > > > > Voting will go on for a minimum of 48 hours. > > > > ————— > > > > I vote +1: > > > > * Ran `coho audit-license-headers` over the relevant repos > > * Ran `coho check-license` to ensure all dependencies and sub- > > dependencies have Apache-compatible licenses > > * Ensured the `npm audit` report was sufficient for release > > * Ensured continuous build was green when repo was tagged > > * Ran `npm test` > > * Ran following `cordova` test in sample project: > > * `cordova platform add cordova-electron-4.0.0.tgz` > > * `cordova plugin add` > > * `cordova build electron` > > * `cordova run electron —nobuild` > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > For additional commands, e-mail: dev-h...@cordova.apache.org >
