On Jan 8, 2015, at 3:10 AM, jan i wrote: > On 8 January 2015 at 00:40, Dennis E. Hamilton <[email protected]> > wrote: > >> -- replying below to -- >> From: jan i [mailto:[email protected]] >> Sent: Wednesday, January 7, 2015 13:51 >> To: [email protected]; [email protected] >> Subject: Re: Coding Standards page >> >> On Wednesday, January 7, 2015, Dennis E. Hamilton <[email protected]> >> wrote: >> >>> PS: I have the SVN definitions for the ODF documents, and I need to >> update >>> them for the Microsoft Office documents. I assume that having these >>> binaries is all right in collections of test documents, so long as they >> are >>> not in the part of our repositories that represent released source code. >> >> It is OK to have binaries for test. Can you please add the right git >> attributes to the main test dir. >> >> <orcmid> >> I don't see a main test dir anywhere. >> If you know of specific file extensions for binary content that we have, >> please update the .gitattributes file at the repository root. I >> couldn't >> Find anything with a quick scan of the repository. >> (The SVN definitions are different and we don't use our SVN that way.) >> </orcmid> >> >> My bad, I have one in my branch but it is not in the repo....I think went > away because peter moved test cases into docFormats, since they were all > white box testing. > > We need a test dir at top level for black box tests, please create one. May > I suggest we add the poi test documents in a subdir, with a readme file > that informs the origin. > > Dave@ thanks for your idea, and for sharing your concern...I think it is > better to have them in our git repo, so developers dont need multiple > version control clients.
Keep in mind that some of these documents are examples of bad documents. It would be necessary to look into POI's unit tests. Having bad documents is good. Regards, Dave > > rgds > jan i > >> [ ... ] >> >>
