On 11 February 2015 at 19:34, Dennis E. Hamilton <[email protected]> wrote:
> -- replying below to -- > From: [email protected] [mailto:[email protected]] > Sent: Wednesday, February 11, 2015 09:18 > To: [email protected] > Subject: incubator-corinthia git commit: Added build instructions. > > Repository: incubator-corinthia > Updated Branches: > refs/heads/master 9e8e44c36 -> c94ae5dd5 > > Added build instructions. > > <orcmid> > Great idea. > > I notice a few things. > > 1. The .sh files are no longer in sync with the .bat > files. The .bat files should be used even when > building with CygWin or MSYS2. I propose to delete > the .sh files to avoid this problem. (There is an > open .bat issue when unzipping to shared files from a > guest OS that has not been isolated yet.) > > > 2. The externals are only meaningful for Windows > builds, whatever platform is targeted for the > compilation. It might be possible to shorten that > lengthy list of CMake options to ones that make > sense for this case. > Which long list ??? I only use -G > > 3. Because of platform differences, it might be > better to separate out the build for each platform > into a separate build text file. > Why, there are no differences. All platforms need to do a "cmake -G" > > 4. I would also separate out the builds we test > with for confirming a buildable release and those > build options that are not tested but that > Someone might experiment with. I would put the > VS 2015 build in that category until VS 2015 > graduates from technology preview to a release. > ???? Are you mixing build instructions with our buildbot setup ? Build instructions, only tells new developers how to compile corinthia on their platform....nothing about tested/released platforms, that should be in other documents. > > 5. With regard to VS builds, it is useful to > know the simplest versions (e.g., Express or > Community) that is the tested case. > That could be information in the general README file. > > Hmm, it might be good to have a job jar about builds. > this note will have to be good enough for starters. > What do you mean by a "job jar" ? I think you see a far bigger purpose of build_instructions.txt than the intention was. rgds jan I. > </orcmid> > >
