On 14 August 2015 at 20:03, jan i <[email protected]> wrote: > > > On 14 August 2015 at 19:53, Peter Kelly <[email protected]> wrote: > >> Hi Jan, >> >> I just tried this version and all none of the tests fail. A quick look at >> some of the files shows they’re now using Windows line endings (\r\n), >> instead of Unix line endings (\n). The test code doesn’t handle this. It >> should, but also the files should have remained in Unix line format after >> they were moved. >> > problem exist on master as well, just checked. I will try and find out why. >
just controlled my notebook and both vms with git config --get core.autocrlf that report true. And I have not changed git setup on my notebook for a long time, so I am confused. rgds jan i. > > rgds > jan i. > > >> >> It’s late here and I don’t know any tools off-hand to check for line >> endings, but tomorrow I’ll put together a script to check and make sure >> we’re using Unix line endings in all the test files. >> >> Later on I’ll modify the tests to handle \r\n, but I think we should >> standardize on a single line ending; I think git can convert where >> necessary with the right setting? >> >> -- >> Dr. Peter M. Kelly >> [email protected] >> http://www.kellypmk.net/ >> >> PGP key: http://www.kellypmk.net/pgp-key >> (fingerprint 5435 6718 59F0 DD1F BFA0 5E46 2523 BAA1 44AE 2966) >> >> On 14 Aug 2015, at 5:09 pm, jan i <[email protected]> wrote: >> >> I have now incorporated all comments from >> - Justin >> - Peter >> - Daniel, note some of the missing ALv2 headers are valid and have been >> explained in a DISCLAIMER file. >> >> I have prepared a new release candidate >> >> >> https://dist.apache.org/repos/dist/dev/incubator/corinthia/incubator-corinthia_release_0.1.zip >> >> and the signature: >> >> >> https://dist.apache.org/repos/dist/dev/incubator/corinthia/incubator-corinthia_release_0.1.zip.asc >> >> >> Peter suggested that in order to avoid having multiple votes, we do a >> "PRE-VOTE", where you all can wet the candidate and I can make updates >> without having to rerun a vote. >> >> For the actual vote we will follow the standard guidelines: >> http://www.apache.org/dev/release.html#approving-a-release >> "Votes on whether a package is ready to be released use majority approval >> <http://www.apache.org/foundation/glossary.html#MajorityApproval> -- >> i.e., >> at least three PMC members must vote affirmatively for release, and there >> must be more positive than negative votes. Releases may not be vetoed." >> >> >> Timeline: >> PRE-VOTE start, Friday 14th August >> PPMC VOTE start, Wednesday 19th August >> IPMC VOTE start, Monday 23th August >> Make release bits (hopefully) 28th August >> >> A couple of remarks to the timeline: >> >> - there has already been several release candidates available starting >> August 9th, so there has been plenty of time to test and we now have 4 >> days. >> >> - PPMC members are welcome to cast their vote in the PRE-VOTE, and I will >> transfer it to the actual vote. >> >> - Even though you have cast a vote, you can change it anytime while the >> PRE-VOTE and VOTE is open. >> >> Looking forward to announce our first release. >> rgds >> jan i. >> >> >> >
