Yeah, I have no love for couch_ref_counter. It's a little subtle, though. I'm not sure that patch is quite ready to be brought upstream. I haven't had any issue with it personally, I just want to see if there's any more elegant way to do it. I definitely think that using monitors as reference counters is a good idea. Let's not reimplement something that's already built into the VM.
Adam On Jan 19, 2011, at 3:40 PM, Benoit Chesneau wrote: > Thanks to commit changes :) I guess last one change from bigcouch > would be the change in db monitoring (replacing ref count) ? > > On Wed, Jan 19, 2011 at 9:33 PM, Adam Kocoloski (JIRA) <j...@apache.org> > wrote: >> >> [ >> https://issues.apache.org/jira/browse/COUCHDB-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel >> ] >> >> Adam Kocoloski closed COUCHDB-1010. >> ----------------------------------- >> >> Resolution: Fixed >> Assignee: Adam Kocoloski (was: Benoit Chesneau) >> >> Committed to trunk >> >>> improve supervision tree and config changes reload >>> -------------------------------------------------- >>> >>> Key: COUCHDB-1010 >>> URL: https://issues.apache.org/jira/browse/COUCHDB-1010 >>> Project: CouchDB >>> Issue Type: Improvement >>> Components: Database Core >>> Affects Versions: 1.2 >>> Reporter: Benoit Chesneau >>> Assignee: Adam Kocoloski >>> Fix For: 1.2 >>> >>> Attachments: 0001-export-functions-to-couch_config.patch, >>> 0002-another-port-from-bigcouch.-i.patch, >>> 0002-another-port-from-bigcouch.-i.patch, >>> 0002-another-port-from-bigcouch.-i.patch, >>> 0003-do-like-in-other-module.-s-couch_os_daemons-MODULE.patch, >>> COUCHDB-1010.patch >>> >>> >>> port from bigcouch which is under apache license 2. >>> - improve supervision >>> - clean config changes handling. >>> This has been tested in an undisclosed yet project named refuge wich is >>> also based on couchdb but is more OTP and rebar friendly. >> >> -- >> This message is automatically generated by JIRA. >> - >> You can reply to this email to add a comment to the issue online. >> >>
