[ https://issues.apache.org/jira/browse/COUCHDB-1344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154109#comment-13154109 ]
Filipe Manana commented on COUCHDB-1344: ---------------------------------------- Thanks for the reminder Randall. For the comparison thing, I couldn't get the JavaScript tests to fail neither on the browser nor via the cli. I added a few days ago an equivalent test to the etap test suite: http://git-wip-us.apache.org/repos/asf?p=couchdb.git;a=commitdiff;h=c9a0d2af;hp=27ce101a3223e2c311b82654caed6363d1fd7288 It also covers deleted changes and the built-in _design filter. Feel free to add any other tests you think that should be there. > add etap coverage for _changes with filters and since > ----------------------------------------------------- > > Key: COUCHDB-1344 > URL: https://issues.apache.org/jira/browse/COUCHDB-1344 > Project: CouchDB > Issue Type: Improvement > Components: Database Core > Affects Versions: 1.2 > Reporter: Randall Leeds > Assignee: Randall Leeds > Priority: Minor > Fix For: 1.2 > > > I described a problem with the js tests for _changes after new filtering > stuff: > > It was the "andmore-only" section near the end: > > T(line.seq == 8) > > T(line.id == "andmore") > > The problem is that seq _should_ be strictly greater than since. > > If you look at couch_db:changes_since/5 and related functions, that > > module adds one to the sequence number in order to get this behavior. > > Only when using filters was this broken and became >=. > Filipe said: > > I've never had such failure locally. If it's due to browser caching, > > it would be a good idea to add a test to test/etap/073-changes.t > I said I'd add an etap test. This ticket is to remind me to do it: > > I can add an etap test. I'm positive it's not browser caching because > > I identified and fixed it. Also, because I just committed a change to > > improve Futon's browser caching :). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira