Done.

On Wed, Mar 21, 2012 at 4:26 AM, Paul Davis <[email protected]> wrote:
> Looks good enough to me. Something something forgiveness something permission.
>
> On Tue, Mar 20, 2012 at 10:40 PM, Jason Smith <[email protected]> wrote:
>> On Wed, Mar 21, 2012 at 9:54 AM, Jason Smith <[email protected]> wrote:
>>> On Wed, Mar 21, 2012 at 9:49 AM, Jason Smith <[email protected]> wrote:
>>>> The regression began at commit ede9482f.
>>>>
>>>> http://git-wip-us.apache.org/repos/asf?p=couchdb.git;a=commitdiff;h=ede9482fc3c9e629572ab1376d88f4499c4c8beb
>>>
>>> In particular, the error is with the change to couch_log.erl.
>>
>> Whoops. I meant couch_file.erl.
>>
>> Randall, please see the attached diff, or see
>> http://friendpaste.com/2Hwjn9uj1oRM8pyRqAdbxc
>>
>> The pattern {Ref, Pid, {error, Reason}} does not match because the
>> message is {Ref, Pid, Reason}
>>
>> I am unfamiliar with this code but I get the test suite passing with
>> the change pushed to 1.2.x-couch_file. If it looks okay to someone
>> more familiar with the issue, would you please merge it with 1.2.x.
>> Thanks!



-- 
Iris Couch

Reply via email to